Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update auth_svc.py #2823

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Update auth_svc.py #2823

merged 4 commits into from
Sep 28, 2023

Conversation

elegantmoose
Copy link
Contributor

@elegantmoose elegantmoose commented Sep 26, 2023 •
edited
Loading

Description

Modified PR from original PR #2820. Added some condition checking for cases when API key is none so that HMAC comparison function doesnt throw exception.

Also made sure global variables for keys were being used in all of module and not the key strings.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally via tests and manually via REST API calls.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@elegantmoose elegantmoose requested a review from clenk September 26, 2023 21:53
clenk
clenk approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@elegantmoose elegantmoose merged commit 60ed4ab into master Sep 28, 2023
7 of 11 checks passed
@elegantmoose elegantmoose deleted the run_tests/use-secure-comparison branch September 28, 2023 15:35
@elegantmoose elegantmoose mentioned this pull request Sep 28, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clenk clenk clenk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elegantmoose @clenk